Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor Android Port #58160

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Editor Android Port #58160

merged 1 commit into from
Mar 28, 2022

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Feb 15, 2022

master version of the Godot Editor Android port based on the work done by @thebestnom in #36776!

This PR cleans a lot of the logic in #36776.

There are still a lot of tweaks, UI cleanup and touch-ups needed to be done before the Editor Android port can be considered suitable for public release and usage. Nonetheless, the current logic is stable enough and partitioned away that we can start reviewing and landing this PR and then iterate on top of it.

Addresses godotengine/godot-proposals#3931

godot_android_editor_on_device_run_through.mp4

Apk Download (only meant for testing and feedback!)

Latest master Godot Editor Android build (all architectures except armv7)

Generate apk from sources

  • Using the regular Godot build process, generate Godot tools android shared libraries for each platform you want the apk to support:
    • e.g: scons tools=true platform=android target=<build_target> android_arch=<android_arch>
    • release_debug is recommended for the target option
    • android_arch should be one of arm64v8, x86 or x86_64
  • Navigate to the platform/android/java directory
  • Run ./gradlew generateGodotEditor
    • The command will generate one apk for each available target
    • The generated apk(s) can be found in the bin directory.

@m4gr3d m4gr3d added this to the 4.0 milestone Feb 15, 2022
@m4gr3d m4gr3d requested review from a team as code owners February 15, 2022 23:30
@m4gr3d m4gr3d mentioned this pull request Feb 15, 2022
Merged
@Calinou
Copy link
Member

Calinou commented Feb 16, 2022 •
edited
Loading

I gave the APK a try on my OnePlus 6 running Android 11. Basic 2D and 3D features are working 🙂

In the project manager, the Vulkan Clustered backend is selected by default in the new project dialog. It should be changed so the Vulkan Mobile backend is selected by default on Android. The Vulkan Clustered option should be disabled with a "Not supported on mobile platforms" description.

While creating a new project works when using the Vulkan Clustered backend, it's actually automatically falling back to Vulkan Mobile (due to the default project setting with a .mobile feature tag). This can cause issues if you transfer a project from mobile to desktop, as a different rendering backend will be used on both devices.

@m4gr3d m4gr3d changed the title Editor Android Port [WIP] Editor Android Port Mar 16, 2022
@m4gr3d @thebestnom
Android port of the Godot Editor
5711037 
These set of changes focus primarily on getting the core logic and overall Godot Editor UI and functionality up and running natively on Android devices.
UI tweaks / cleanup / polish, as well configuration for Android specific functionality / restrictions will be addressed in follow-up PRs iteratively based on feedback.

Co-authored-by: thebestnom <shoval.arad@gmail.com>
@m4gr3d m4gr3d changed the title [WIP] Editor Android Port Editor Android Port Mar 28, 2022
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Mar 28, 2022

@akien-mga Updated the PR with the changes and feedback from the 3.x version; it's ready to merge!

@akien-mga akien-mga merged commit fd0716c into godotengine:master Mar 28, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Mar 28, 2022
Closed
5 tasks
@m4gr3d m4gr3d deleted the android_editor branch March 28, 2022 22:17
@aaronfranke aaronfranke mentioned this pull request Mar 29, 2022
Closed
@pranshuthegamer
Copy link

How can i test this apk?

@arkology
Copy link
Contributor

@akien-mga Will the editor binaries for Android be available, for example, in the next alpha?
Or this is something that should be done manually? (I don't know anything about this, that's why I'm asking)

@himaghnam
Copy link

please include this in github build process - Actions

@Calinou
Copy link
Member

Calinou commented Mar 29, 2022 •
edited
Loading

The testing APK linked at the top of this pull request should still work for now (including the one in the 3.x pull request).

Note: Google Drive download links don't work if your browser blocks third-party cookies.

Edit: 3.5beta4 has an official Android editor APK listed on the release announcement.

@aaronfranke aaronfranke mentioned this pull request Mar 30, 2022
Closed
@NicoleKai
Copy link

THIS IS SOOOOO COOOOLL!!!! HOLY COW I CAN GAME DEV FROM ANYWHERE!

@Yasserpro312
Copy link

add touch support to the ui
right now you can't delete nodes or files and can't create folders without mouse and keyboard
so please add touch support with the next update

@Calinou
Copy link
Member

Calinou commented Apr 22, 2022

add touch support to the ui right now you can't delete nodes or files and can't create folders without mouse and keyboard so please add touch support with the next update

This is already planned, but it'll take a while to happen as there are relatively few contributors interested to work on the Android editor currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Calinou Calinou Awaiting requested review from Calinou

@thebestnom thebestnom Awaiting requested review from thebestnom

Assignees
No one assigned
Labels
enhancement platform:android topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
8 participants
@m4gr3d @Calinou @akien-mga @pranshuthegamer @arkology @himaghnam @NicoleKai @Yasserpro312